Add FXIOS-13851 [Japan MSCA] Add Firefox Japanese Guide deafult site#30384
Merged
Add FXIOS-13851 [Japan MSCA] Add Firefox Japanese Guide deafult site#30384
Conversation
🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ ✅ Per-file coverageAll changed files meet the threshold of 35.0%. Client.app: Coverage: 37.15
libStorage.a: Coverage: 55.68
Generated by 🚫 Danger Swift against 3446fd4 |
ih-codes
reviewed
Nov 6, 2025
| if shouldExcludeFirefoxJpGuide() { | ||
| /// Assumes the Firefox Japanese Guide is the first default site in the list in the `ja_JP` locale in | ||
| /// `DefaultSuggestedSites.swift` | ||
| suggested.remove(at: 0) |
Collaborator
There was a problem hiding this comment.
Can we search and remove to be safer, maybe key on the title or URL or something? 👀
| return suggested.filter({ deleted.firstIndex(of: $0.url) == .none }) | ||
| } | ||
|
|
||
| private func shouldExcludeFirefoxJpGuide() -> Bool { |
Collaborator
There was a problem hiding this comment.
nit; This could probably be a getter var since the method doesn't include params.
ih-codes
reviewed
Nov 6, 2025
Collaborator
There was a problem hiding this comment.
Oh, one more thing. I used ImageOptim to compress this losslessly down to 15 KB. I'll DM you the asset! 👀
ih-codes
approved these changes
Nov 6, 2025
Comment on lines
+85
to
+90
| if shouldExcludeFirefoxJpGuide { | ||
| // Remove the Firefox Japanese Guide from the list of default sites | ||
| suggested.removeAll { | ||
| $0.url == DefaultSuggestedSites.firefoxJpGuideURL | ||
| } | ||
| } |
Contributor
|
🚀 PR merged to |
Foxbolts
changed the title
This was referenced Jan 21, 2026
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
ja_JPlocaleja_JPlocale default site order so that Yahoo comes before Ambelo🎥 Demos
📝 Checklist