Skip to content

Add FXIOS-13851 Add Firefox Japanese Guide deafult site #30384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add FXIOS-13851 Add Firefox Japanese Guide deafult site #30384

wants to merge 5 commits into from

Conversation

@Foxbolts
Copy link
Collaborator

@Foxbolts Foxbolts commented Nov 5, 2025 •
edited
Loading

⚠️ Currently in draft while I investigate a workaround for caching the redirected Firefox Japanese Guide URL instead of the shortened link, causing an unwanted duplicated shortcut to appear

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Add the Firefox Japanese Guide as a default site
  • Reorder ja_JP default site order so that Yahoo is above Ambelo

🎥 Demos

Simulator Screenshot - iPhone 17 - 2025-11-04 at 19 13 45

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 5, 2025

Messages
📖 Project coverage: 38.64%

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.06

File Coverage
NimbusFlaggableFeature.swift 95.6% ✅
TopSitesProvider.swift 96.53% ✅
NimbusFeatureFlagLayer.swift 77.27% ✅

libStorage.a: Coverage: 56.42

File Coverage
DefaultSuggestedSites.swift 90.91% ✅

Generated by 🚫 Danger Swift against eb91272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Foxbolts @mobiletest-ci-bot